Skip to content

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Apr 30, 2024

Update Envoy image to a version that includes the source port in upstream connection pool hash, so that each unique downstream connection gets a dedicated upstream connection.

Backport note: Backport once the cilium/proxy change is backported to the relevant release branches (cilium/proxy v1.27 & v1.28)

Fixes: #27762

Envoy upstream connections are now unique for each downstream connection when using the original source address of a source pod.

@jrajahalme jrajahalme added release-note/bug This PR fixes an issue in a previous release of Cilium. dont-merge/preview-only Only for preview or testing, don't merge it. labels Apr 30, 2024
@jrajahalme jrajahalme requested review from a team as code owners April 30, 2024 19:27
@jrajahalme
Copy link
Member Author

/test

@jrajahalme
Copy link
Member Author

/test

@jrajahalme jrajahalme force-pushed the envoy-use-port-in-conn-pool branch from 288b6a0 to fc54828 Compare May 2, 2024 06:23
@jrajahalme jrajahalme added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/bug This is a bug in the Cilium logic. needs-backport/1.13 backport/author The backport will be carried out by the author of the PR. and removed dont-merge/preview-only Only for preview or testing, don't merge it. labels May 2, 2024
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jrajahalme
Copy link
Member Author

/test

@sayboras sayboras enabled auto-merge May 2, 2024 07:06
Update Envoy image to a version that includes the source port in upstream
connection pool hash, so that each unique downstream connection gets a
dedicated upstream connection.

Fixes: cilium#27762
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme force-pushed the envoy-use-port-in-conn-pool branch from fc54828 to d075c5c Compare May 2, 2024 08:14
@jrajahalme
Copy link
Member Author

Rebased to resolve conflict in git diff context.

@jrajahalme
Copy link
Member Author

/test

@sayboras sayboras added this pull request to the merge queue May 2, 2024
Merged via the queue into cilium:main with commit d5efd28 May 2, 2024
@jrajahalme jrajahalme added backport-pending/1.13 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.13 labels May 3, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport/author The backport will be carried out by the author of the PR. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
Status: Released
Status: Released
Status: Released
Development

Successfully merging this pull request may close these issues.

CI: Conformance E2E: client-egress-l7-named-port/pod-to-pod: command terminated with exit code 28 (timeout)
3 participants