Skip to content

bpf: add multicast in MAX_OVERLAY_OPTIONS #32129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

bpf: add multicast in MAX_OVERLAY_OPTIONS #32129

merged 1 commit into from
Apr 23, 2024

Conversation

harsimran-pabla
Copy link
Contributor

Fix mismatched brackets in multicast code and add ENABLE_MULTICAST in MAX_OVERLAY_OPTIONS to check such mismatches during compile time in future.

@harsimran-pabla
bpf: add multicast in MAX_OVERLAY_OPTIONS
7676092 
Fix mismatched brackets in multicast code and add ENABLE_MULTICAST in
MAX_OVERLAY_OPTIONS to check such mismatches during compile time in
future.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Apr 22, 2024
@harsimran-pabla harsimran-pabla requested review from a team as code owners April 22, 2024 15:07
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. labels Apr 22, 2024
julianwiedmann
julianwiedmann approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@julianwiedmann
Copy link
Member

/test

@harsimran-pabla
Copy link
Contributor Author

ci-ginkgo: #32075

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 23, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 23, 2024
Merged via the queue into cilium:main with commit 33f01d1 Apr 23, 2024
@julianwiedmann julianwiedmann mentioned this pull request May 3, 2024
Merged
7 tasks
@julianwiedmann julianwiedmann added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label May 9, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 22, 2024
@michi-covalent michi-covalent mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

+1 more reviewer

@nickolaev nickolaev nickolaev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/multicast Impacts the Multicast feature. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.15.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsimran-pabla @julianwiedmann @dylandreimerink @nickolaev