Skip to content

Fix invalid PromQL query in the Cilium Metrics Grafana dashboard #32017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Fix invalid PromQL query in the Cilium Metrics Grafana dashboard #32017

merged 1 commit into from
May 13, 2024

Conversation

mikemykhaylov
Copy link
Contributor

@mikemykhaylov mikemykhaylov commented Apr 17, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

The existing query for the Policies per Node chart in the Cilium Metrics dashboard in the monitoring-example.yaml contained invalid PromQL. Additionally, the correct value to be filtered on is "failure", not "fail".

Fix PromQL query in Cilium Metrics dashboard
Screenshot 2024-04-16 at 20 02 06

@mikemykhaylov mikemykhaylov requested a review from a team as a code owner April 17, 2024 03:11
@mikemykhaylov mikemykhaylov requested a review from joamaki April 17, 2024 03:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 17, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 17, 2024
@maintainer-s-little-helper
Copy link

Commit ab0dca3 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Apr 18, 2024
joamaki
joamaki requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please remove the merge commit.

@mikemykhaylov
Copy link
Contributor Author

Should be good now

@ti-mo ti-mo added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Apr 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 24, 2024
@aanm aanm requested a review from joamaki May 2, 2024 09:20
@aanm
Copy link
Member

aanm commented May 2, 2024

/test

@aanm aanm enabled auto-merge May 2, 2024 09:20
@joamaki
Copy link
Contributor

joamaki commented May 7, 2024

/test

@julianwiedmann julianwiedmann added the area/metrics Impacts statistics / metrics gathering, eg via Prometheus. label May 13, 2024
@mikemykhaylov @julianwiedmann
Fix incorrect PromQL query
6bb2da9 
Signed-off-by: Michael Mykhaylov <32168861+mikemykhaylov@users.noreply.github.com>
@julianwiedmann
Copy link
Member

/test

@aanm aanm added this pull request to the merge queue May 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 13, 2024
@julianwiedmann
Copy link
Member

Added backport labels, sounds like this is essentially a docs bug.

Merged via the queue into cilium:main with commit a37fd43 May 13, 2024
@mikemykhaylov mikemykhaylov deleted the fix-grafana-dashboard-query branch May 13, 2024 19:06
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 23, 2024
Merged
15 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels May 23, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
Merged
12 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels May 24, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 25, 2024
This was referenced Jun 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
cilium v1.14.12
Status: Released
cilium v1.15.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikemykhaylov @aanm @joamaki @julianwiedmann @ti-mo @YutaroHayakawa