Skip to content

bpf: minor tail-call cleanups #31990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2024
Merged

bpf: minor tail-call cleanups #31990

merged 2 commits into from
Apr 17, 2024

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Apr 16, 2024 •
edited
Loading

Continue the migration from #30001, to improved wrappers with __must_check annotation and ext_err reporting.

@julianwiedmann
bpf: clean up last ep_tail_call() occurences
f90869f 
Switch over some multicast code that was recently introduced.

Then remove the deprecated wrapper, and its coccinelle infrastructure.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: introduce tail_call_policy_*() helpers
5f095fa 
Add __must_check wrappers to ensure that callers handle the error.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Apr 16, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title Pr/jwi/main/bpf tail calls bpf: minor tail-call cleanups Apr 16, 2024
@julianwiedmann julianwiedmann marked this pull request as ready for review April 16, 2024 13:22
@julianwiedmann julianwiedmann requested a review from a team as a code owner April 16, 2024 13:22
@julianwiedmann julianwiedmann requested a review from markpash April 16, 2024 13:22
@julianwiedmann julianwiedmann added this pull request to the merge queue Apr 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 17, 2024
Merged via the queue into main with commit b52df67 Apr 17, 2024
@julianwiedmann julianwiedmann deleted the pr/jwi/main/bpf-tail-calls branch April 17, 2024 07:53
@julianwiedmann julianwiedmann mentioned this pull request May 3, 2024
Merged
7 tasks
@julianwiedmann julianwiedmann added the backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. label May 9, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 22, 2024
@michi-covalent michi-covalent mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markpash markpash markpash approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.15.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianwiedmann @markpash