-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Revert "daemon: Forbid IPv6 BPF masquerading with the host firewall" #31511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
From what I remember in #23165, we were concerned about HostFW and IPv6 BPF Masq interacting. But turns out the problematic interaction was for HostFW and iptables Masquerading (ie. when BPF Masq is disabled). This is what #28813 fixed. So afaik there were no actual problems for HostFW and IPv6 BPF Masq, and 👍 on allowing this combo. We could even backport, but at this point I don't see the need. |
#31511 enabled the combination of HostFW with IPv6 BPF Masquerading. Reflect this in the cilium-config action. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
#31511 enabled the combination of HostFW with IPv6 BPF Masquerading. Reflect this in the cilium-config action. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Hey @qmonnet @julianwiedmann , would it be possible to backport this to 1.15? We're currently facing problems when upgrading from a custom build image (based on 1.15.6 with this fix in it) to 1.16. |
@sebastiangaiser This is not something that we expect to backport at the moment (see the backport criteria). I don't remember testing IPv6 masquerading with the Host Firewall on v1.15 so I'm not super keen. What's your problem, and how would backporting to 1.15 solve it (considering you already have this commit in your own image, from what I understand)? |
@qmonnet thank you for your answer. We're facing |
Thank you, I see, but I'm still reluctant to backporting a new feature (or even the possibility to activate it) on v1.15. Given that you based your workflow on custom images, you're “outside” of the regular support path, and it's hard to justify making an exception here. How hard would it be to carry on the commit to a custom image based on the latest 1.15 release on your side? From there you should be able to move on to 1.16? |
This reverts commit 934e1f2.
Since commit 9c1031e ("bpf: fix missing ipv6 ct entry for snated traffic"), IPv6 BPF masquerading and the host firewall are compatible in the datapath. Let's allow them to be used together, and use the combination in tests.
CC: @oblazek
Supersedes: #26323