labelsfilter: Ensure entity relevant labels are always applied #31178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Entities are special selectors used by network policies. The Cluster entity relies on the `io.cilium.k8s.policy.cluster` label which is removed by Cilium if a strict identity label configuration is applied. This PR adds the relevant Cilium policy label to the list of default labels so it will always be applied regardless of configuration, and includes this label to the associated test file. Fixes: cilium#18878 Signed-off-by: soggiest <nicholas@isovalent.com>
9361d6e to
be5a244
Compare
|
I realized my previous commit contained an extra label that wasn't actually used by as a selector for |
squeed
approved these changes
Mar 11, 2024
|
/test |
|
Would someone mind kicking off another test, the errors I'm seeing from the EKS and Ginkgo tests don't seem related to my change. I'm wondering if these are flakes. Tangent question: Why is this network policy file named |
|
Tangent looks like a bug. May be worth filing an issue and/or PR and/or use |
marseel
added a commit
to marseel/cilium
that referenced
this pull request
Oct 17, 2024
PR cilium#31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: cilium#31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Oct 22, 2024
[ upstream commit d3dc7e8 ] [ backporter's note: added `any:` prefix as with other labels because commit fee6107 ("metrics: add lower-cardinality metrics for node connectivity") which removes these prefixes across all docs wasn't backported. ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: #31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Oct 22, 2024
[ upstream commit d3dc7e8 ] [ backporter's note: added `any:` prefix as with other labels because commit fee6107 ("metrics: add lower-cardinality metrics for node connectivity") which removed these prefixes across all docs wasn't backported to v1.16. ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: #31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Oct 22, 2024
[ upstream commit d3dc7e8 ] [ backporter's note: added `any:` prefix as with other labels because commit 1918908 ("Improve identity-relevant-labels.rst page") which removed these prefixes across all docs wasn't backported to v1.16. ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: #31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
[ upstream commit d3dc7e8 ] [ backporter's note: added `any:` prefix as with other labels because commit 1918908 ("Improve identity-relevant-labels.rst page") which removed these prefixes across all docs wasn't backported to v1.16. ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones that are propagated even when strict filters are applied. Fixes: #31178 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
liyihuang
added a commit
to liyihuang/cilium
that referenced
this pull request
Dec 12, 2024
PR cilium#31178 added "io.cilium.k8s.policy.cluster" label to default ones but didn't update the doc PR cilium#35422 added the label in the doc but didn't update the example Fixes: cilium#31178 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Dec 16, 2024
[ upstream commit 4b4f45e ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but didn't update the doc PR #35422 added the label in the doc but didn't update the example Fixes: #31178 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Dec 19, 2024
[ upstream commit 4b4f45e ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but didn't update the doc PR #35422 added the label in the doc but didn't update the example Fixes: #31178 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
pushed a commit
that referenced
this pull request
Dec 19, 2024
[ upstream commit 4b4f45e ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but didn't update the doc PR #35422 added the label in the doc but didn't update the example Fixes: #31178 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
[ upstream commit 4b4f45e ] PR #31178 added "io.cilium.k8s.policy.cluster" label to default ones but didn't update the doc PR #35422 added the label in the doc but didn't update the example Fixes: #31178 Signed-off-by: Liyi Huang <liyi.huang@isovalent.com> Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entities are special selectors used by network policies. The Cluster entity relies on the
io.cilium.k8s.policy.clusterlabel to select endpoints which is removed by Cilium if a strict identity label configuration is applied. This PR adds the relevant Cilium policy label to the list of default labels so it will always be applied regardless of configuration, and includes this label to the associated test.Fixes: #18878
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.