Skip to content

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Mar 4, 2024

Adds AWS IPv6 Prefix Delegation (PD) option to Cilium Operator.

  • operator/option/config.go: Adds an option for enabling AWS IPv6 prefix delegation (PD).
  • *_test.go: Updates IPAM implementation unit tests to call NewNodeManager() with IPv6 PD config option.
  • pkg/ipam/node.go: Adds GetNeededIPv6Addresses() to return the number of IPv6 addresses that need to be allocated or released.
  • pkg/ipam/node_manager.go: Adds IPv6 PD field to the NodeManager type and associated NewNodeManager(). Updates Upsert() to create IPv6 allocation attributes if IPv6 PD is enabled.
    Adds GetNodesByIPv6WatermarkLocked() to return all nodes that require IPv6 addresses to be allocated or released. Updates Resync() to resync nodes that require IPv6 addresses to be allocated or released when IPv6 PD is enabled.

Supports: #19251

 Adds "aws-enable-ipv6-prefix-delegation" operator option for configuring AWS ENI IPv6 prefix delegation.

@danehans danehans requested review from a team as code owners March 4, 2024 21:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2024
@danehans danehans changed the title IPAM: Adds IPv6 Prefix Delegation Config Option IPAM: Adds AWS IPv6 Prefix Delegation Config Option Mar 4, 2024
@danehans danehans force-pushed the issue_19251_cfg_option branch 2 times, most recently from 0f3f659 to e053aff Compare March 6, 2024 22:05
@christarazi christarazi marked this pull request as draft March 11, 2024 19:04
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Apr 11, 2024
@danehans danehans force-pushed the issue_19251_cfg_option branch from e053aff to 38d0420 Compare April 24, 2024 21:30
@danehans danehans marked this pull request as ready for review April 24, 2024 21:30
@github-actions github-actions bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Apr 25, 2024
@christarazi
Copy link
Member

Can you rebase @danehans?

@christarazi christarazi marked this pull request as draft April 30, 2024 22:02
@danehans danehans force-pushed the issue_19251_cfg_option branch from 38d0420 to 2d85063 Compare May 2, 2024 17:59
@danehans danehans marked this pull request as ready for review May 2, 2024 17:59
@danehans danehans added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label May 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 3, 2024
@danehans
Copy link
Contributor Author

danehans commented May 3, 2024

/test

@christarazi christarazi added area/eni Impacts ENI based IPAM. sig/ipam area/ipam IP address management, including cloud IPAM labels May 3, 2024
@danehans
Copy link
Contributor Author

danehans commented May 7, 2024

/ci-clustermesh

@danehans
Copy link
Contributor Author

/ci-e2e-upgrade

@danehans
Copy link
Contributor Author

/ci-ginkgo

@danehans
Copy link
Contributor Author

/ci-ipsec-e2e

@danehans
Copy link
Contributor Author

danehans commented May 15, 2024

/ci-runtime

Edit: #32595

@christarazi christarazi enabled auto-merge May 16, 2024 18:25
@christarazi
Copy link
Member

/ci-runtime

Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jun 16, 2024
- `operator/option/config.go`: Adds an option for enabling AWS IPv6 prefix delegation (PD).
- `*_test.go`: Updates IPAM implementation unit tests to call `NewNodeManager()` with IPv6 PD config option.
- `pkg/ipam/node.go`: Adds `ipv6Alloc` field to `Node` type to represent IPv6-specific allocation node attributes.
- `pkg/ipam/node_manager.go`: Adds IPv6 PD field to the `NodeManager` type and associated `NewNodeManager()`.

Supports: cilium#30684

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@aanm aanm force-pushed the issue_19251_cfg_option branch from 2d85063 to 531ee81 Compare June 17, 2024 07:39
@aanm
Copy link
Member

aanm commented Jun 17, 2024

/test

@christarazi christarazi added this pull request to the merge queue Jun 17, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2024
Merged via the queue into cilium:main with commit 2fc54dd Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eni Impacts ENI based IPAM. area/ipam IP address management, including cloud IPAM ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants