iptables: Simplify proxy rules removing ingress/egress flag #31068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ccdaf55 to
d24fac8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d24fac8 to
970fc1a
Compare
|
/test |
dylandreimerink
approved these changes
Mar 4, 2024
|
Gentle ping to @tommyp1ckles for the review 🙏 |
This was referenced Mar 13, 2024
tommyp1ckles
approved these changes
Mar 15, 2024
The proxy rules installed by the iptables manager are the same regardless of the traffic direction (ingress or egress). So, there is no point in having separate functions to install them, nor passing a boolean flag indicating the traffic direction of the proxy. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
The exported iptables manager method that allows to install the rules needed to redirect traffic to a proxy requires a flag to specify the proxy traffic direction. Since the installed rules do not depend on the traffic direction, there is no need to require that flag in the InstallProxyRules method signature. The relevant interfaces and mock implementations are updated accordingly. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
970fc1a to
8c137f3
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy rules installed by the iptables manager are the same regardless of the traffic direction (ingress or egress). So, there is no point in having separate functions to install them, nor passing a boolean flag indicating the traffic direction of the proxy.
The relevant interfaces and mock implementations are updated accordingly.