Skip to content

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Feb 21, 2024

datapath/linux: move creation of features.h to daemon startup

Remove another side-effect from CheckRequirements.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

datapath/linux: require HAVE_LARGE_INSN_LIMIT

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

Updates: #30456

@lmb lmb added the release-note/misc This PR makes changes that have no direct user impact. label Feb 21, 2024
@lmb lmb changed the title 54 require large insn limit require large instruction limit Feb 21, 2024
@lmb
Copy link
Contributor Author

lmb commented Feb 21, 2024

/test

@lmb lmb marked this pull request as ready for review February 21, 2024 18:05
@lmb lmb requested review from a team as code owners February 21, 2024 18:05
@lmb lmb requested review from rgo3 and danehans February 21, 2024 18:06
lmb added 2 commits February 22, 2024 09:33
Remove another side-effect from CheckRequirements.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the 54-require-large-insn-limit branch from a7bf8d8 to cb9b3a3 Compare February 22, 2024 09:33
@lmb
Copy link
Contributor Author

lmb commented Feb 22, 2024

/test

@lmb lmb added this pull request to the merge queue Feb 23, 2024
Merged via the queue into cilium:main with commit 0fa767a Feb 23, 2024
@lmb lmb deleted the 54-require-large-insn-limit branch February 23, 2024 09:45
julianwiedmann added a commit to julianwiedmann/cilium that referenced this pull request Jun 11, 2024
We already require a 5.4 kernel
(cilium#30869). We also explicitly check for
HAVE_LARGE_INSN_LIMIT (cilium#30896), which
afaik was the main reason for the 5.2 kernel requirement.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 12, 2024
We already require a 5.4 kernel
(#30869). We also explicitly check for
HAVE_LARGE_INSN_LIMIT (#30896), which
afaik was the main reason for the 5.2 kernel requirement.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants