datapath: Remove LoadBalancerNodeAddresses & LocalAddresses methods #30458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
commented
Jan 26, 2024
|
One bit of background here: I'm working on removing all "wrappers" for retrieving data from the Table[NodeAddress] with the goal of making it obvious that we need to observe the table for changes and thus perform reconciliation if it changes. NodeAddressing in particular hides the fact that the data is dynamic. |
a346fa0 to
ec45a20
Compare
|
/test |
ec45a20 to
56ed413
Compare
|
/test |
28 tasks
da40232 to
04ee127
Compare
|
/test |
04ee127 to
c1df40e
Compare
|
This pull request has been automatically marked as stale because it |
|
This pull request has not seen any activity since it was marked stale. |
c1df40e to
b7c84d0
Compare
b7c84d0 to
22c2e8d
Compare
|
The next steps after this is to remove the rest of |
|
/test |
4967bdc to
69c1a53
Compare
|
/test |
69c1a53 to
b19c569
Compare
|
/test |
thorn3r
approved these changes
May 6, 2024
b19c569 to
c06478e
Compare
|
/test |
The recently introduced darwin build check in the "Check if build works for every commit" started to fail now due to the use of the unix package and the RT_* constants. Inline these constants into the tables package in order to keep it buildable for non-Linux platforms. Signed-off-by: Jussi Maki <jussi@isovalent.com>
LoadBalancerNodeAddresses() and LocalAddresses() methods in NodeAddressing were simple queries around the Table[NodeAddress]. Since all use-sites are now modularized and it's easy to pass Table[NodeAddress] in, remove these methods from NodeAddressing. NodeAddressing concept itself will be eventually removed, with node addresses available via Table[NodeAddress] and the rest via LocalNodeStore. Signed-off-by: Jussi Maki <jussi@isovalent.com>
c06478e to
92e036a
Compare
|
/test |
rgo3
approved these changes
May 8, 2024
jibi
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadBalancerNodeAddresses() and LocalAddresses() methods in NodeAddressing were simple queries around the Table[NodeAddress]. Since all use-sites are now modularized and it's easy to pass Table[NodeAddress] in, remove these methods from NodeAddressing.
NodeAddressing concept itself will be eventually removed, with node addresses available via Table[NodeAddress] and the rest via LocalNodeStore.