Periodically sync ENI limits using EC2 API to update newly launched AWS instance info. #30308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e8bf4f to
d09e947
Compare
This commit refactors the limits package. Instead of passing the ec2Client struct, we define an interface containing the GetInstanceTypes EC2 API method. This allows us to write unit tests for this function using EC2 mock API client. Signed-off-by: Anish Shah <anishshah@google.com>
With this change, we will periodically sync ENI limits using EC2 API. This will help dynamically updating the ENI limits when a new AWS instance is launched without needing to restart cilium. Fixes cilium#28424 Signed-off-by: Anish Shah <anishshah@google.com>
d09e947 to
ae3b9ac
Compare
christarazi
approved these changes
Jan 18, 2024
|
@christarazi , do you think this change is safe enough to be backported? |
|
Backports are subject to the backporting criteria. From what I can tell, this PR could be considered for v1.15 backport, but any further seems to be a stretch according to the criteria. |
|
Thanks, @christarazi. Can you help with triggering the remaining tests? |
|
/test |
|
any idea if some tests are flaky? The test failure doesn't seem to be related to my change. How can I retrigger tests? |
|
I've retriggered the tests as they were flakes. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
I'm periodically calling
GetInstanceTypesEC2 API call to keep updating ENI limits. I think this is overkill (since AWS might be launched only a few new instances per year). But I think it is ok as there are only hundreds of AWS instances and shouldn't impact memory/network perf.Another alternative is to lazy fetch new instance type only when we don't find the instance type. I tried implementing this approach but it required a lot of refactoring.
Fixes: #28424