Loader modularization #30280
Merged
Loader modularization #30280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits 4c7104b, 68e8cf8 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
68e8cf8 to
ae50dbe
Compare
22e49b7 to
a65974a
Compare
|
/test |
rgo3
approved these changes
Jan 18, 2024
asauber
approved these changes
Jan 20, 2024
ti-mo
approved these changes
Jan 22, 2024
a65974a to
e1e7ed2
Compare
|
/test |
This commit unexports all types and functions on the package itself except for the Loader interface. All functions accessed from outside the package now are methods of this interface. This makes the API boundary of the loader package more explicit and easier to reason about and refactor. It is also a first step towards turning the loader package into a module. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This commit changes the loader into a cell. The Datapath object depends on it and re-distributes it still (for now). All locations that created a loader now reuse the loader instance from hive. The exception being tests which did not yet use hive. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
e1e7ed2 to
3b31891
Compare
28 tasks
|
/test |
markpash
approved these changes
Jan 23, 2024
mhofstetter
approved these changes
Jan 24, 2024
aanm
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the eBPF loader in
pkg/datapath/loaderinto a Hive cell. It also unexported all symbols where possible. Global functions which were called outside of the package have been moved to the Loader interface so we have a single clear API boundary, making it easier to improve upon in the future.This step will also make it easier to move non-loader logic outside of the package by allowing us to then still depend on the logic via hive.
Part of #30024