loader: insert policy programs before attaching bpf entrypoints, enforce missed tail calls in ci-e2e #30248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
2acc01e to
e88fc22
Compare
|
/test |
See code comments for a detailed description of the problem. This commit installs policy programs before attaching tc/xdp hooks since doing things in the wrong order means dropping tail calls when handling traffic if the policy programs aren't inserted. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
e88fc22 to
251be03
Compare
|
/test |
|
This did 8 consecutive successful rounds of ci-e2e, so I'm calling it. No more missing tail calls (for now)! Marking this as ready for review. (Aside from hitting #30266 on a few occasions, of course.) |
brlbil
approved these changes
Jan 17, 2024
rgo3
approved these changes
Jan 17, 2024
This was referenced Jan 17, 2024
Closed
2 tasks
2 tasks
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the early days of Cilium, we would miss tail calls in CI and not really monitor when or how these happened. Many improvements have been made in recent months to make these a thing of the past, but they were still occurring with host-fw enabled.
After the most recent round of fixes, most of these errors disappeared, but one bugbear remained. This PR addresses the final outstanding error in ordering prog array insertions:
Finally, strictly enforce no missed tail calls in all ci-e2e scenarios.
Fixes: #29476