Skip to content

test: standalone l4lb add test to verify that rqs to service do not fail when agent is starting #30114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

test: standalone l4lb add test to verify that rqs to service do not fail when agent is starting #30114

merged 1 commit into from
Feb 8, 2024

Conversation

oblazek
Copy link
Contributor

@oblazek oblazek commented Jan 5, 2024 •
edited
Loading

Related slack thread: https://cilium.slack.com/archives/CDKG8NNHK/p1704378628377709

Fix was merged yesterday, so it's already present in the cilium-ci release, tested locally that it now works as expected.

test: add standalone l4lb test to verify that traffic works even when cilium agent is restarted

Signed-off-by: Ondrej Blazek ondrej.blazek@firma.seznam.cz

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 5, 2024
@oblazek
Copy link
Contributor Author

oblazek commented Jan 5, 2024

/ci-l4lb

@oblazek
Copy link
Contributor Author

oblazek commented Jan 5, 2024

/test

@maintainer-s-little-helper
Copy link

Commit a5cb525 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 5, 2024
@oblazek
Copy link
Contributor Author

oblazek commented Jan 5, 2024

/ci-l4lb

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 5, 2024
@oblazek
Copy link
Contributor Author

oblazek commented Jan 5, 2024

/ci-l4lb

@oblazek oblazek changed the title test: l4lb verify that rqs to service fail when agent is starting test: l4lb add test to verify that rqs to service do not fail when agent is starting Jan 10, 2024
@oblazek oblazek mentioned this pull request Jan 10, 2024
Merged
@oblazek oblazek force-pushed the ob-l4lb-fail branch 2 times, most recently from 5736373 to adb2850 Compare January 11, 2024 08:00
@oblazek oblazek marked this pull request as ready for review January 11, 2024 08:02
@oblazek oblazek requested review from a team as code owners January 11, 2024 08:02
@oblazek oblazek requested review from aspsk and tklauser January 11, 2024 08:02
@oblazek oblazek changed the title test: l4lb add test to verify that rqs to service do not fail when agent is starting test: standalone l4lb add test to verify that rqs to service do not fail when agent is starting Jan 11, 2024
@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label Jan 11, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2024
@tklauser
Copy link
Member

/ci-l4lb

@tklauser tklauser mentioned this pull request Jan 11, 2024
Closed
@oblazek
Copy link
Contributor Author

oblazek commented Jan 11, 2024

ci-l4lb test results here https://github.com/cilium/cilium/actions/runs/7486837738

aspsk
aspsk reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one minor question

@tklauser tklauser enabled auto-merge January 12, 2024 09:20
@tklauser
Copy link
Member

/test

1 similar comment
@oblazek
Copy link
Contributor Author

oblazek commented Jan 29, 2024

/test

@oblazek
test: extend l4lb test when agent is restarting
cb32909 
Add a test so that traffic continues to work when cilium agent
is being restarted. Bpf programs should be atomically swaped
so there shouldn't be any drops.

Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
auto-merge was automatically disabled February 5, 2024 13:26

Head branch was pushed to by a user without write access

@oblazek
Copy link
Contributor Author

oblazek commented Feb 5, 2024

rebased, retriggering tests

@oblazek
Copy link
Contributor Author

oblazek commented Feb 5, 2024

/test

@oblazek
Copy link
Contributor Author

oblazek commented Feb 5, 2024

/ci-runtime

@oblazek
Copy link
Contributor Author

oblazek commented Feb 6, 2024

/ci-ginkgo

@oblazek
Copy link
Contributor Author

oblazek commented Feb 6, 2024

/ci-l4lb

@oblazek
Copy link
Contributor Author

oblazek commented Feb 7, 2024

/ci-ginkgo

@tklauser tklauser enabled auto-merge February 7, 2024 09:10
@oblazek oblazek mentioned this pull request Feb 7, 2024
Closed
@oblazek
Copy link
Contributor Author

oblazek commented Feb 7, 2024

/ci-ginkgo

1 similar comment
@oblazek
Copy link
Contributor Author

oblazek commented Feb 8, 2024

/ci-ginkgo

@tklauser tklauser added this pull request to the merge queue Feb 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 8, 2024
Merged via the queue into cilium:main with commit 4d05b07 Feb 8, 2024
borkmann added a commit that referenced this pull request Feb 12, 2024
@borkmann
cilium, tests: Temporary disable agent restart test in l4lb
bc10f0a 
The test is currently causing a lot of flakes, so it looks like we
need to revisit #30163 to figure out why it is still not addressed.

Related: #30114
Closes: #30707
Closes: #24728
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann mentioned this pull request Feb 12, 2024
Merged
borkmann added a commit that referenced this pull request Feb 12, 2024
@borkmann
cilium, tests: Temporary disable agent restart test in l4lb
4751571 
The test is currently causing a lot of flakes, so it looks like we
need to revisit #30163 to figure out why it is still not addressed.

Related: #30114
Closes: #30707
Closes: #24728
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
dlapcevic pushed a commit to dlapcevic/cilium that referenced this pull request Feb 13, 2024
@borkmann @dlapcevic
cilium, tests: Temporary disable agent restart test in l4lb
a9b394f 
The test is currently causing a lot of flakes, so it looks like we
need to revisit cilium#30163 to figure out why it is still not addressed.

Related: cilium#30114
Closes: cilium#30707
Closes: cilium#24728
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Pionerd pushed a commit to Pionerd/cilium that referenced this pull request Feb 13, 2024
@borkmann @Pionerd
cilium, tests: Temporary disable agent restart test in l4lb
41673c7 
The test is currently causing a lot of flakes, so it looks like we
need to revisit cilium#30163 to figure out why it is still not addressed.

Related: cilium#30114
Closes: cilium#30707
Closes: cilium#24728
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oblazek @tklauser @aspsk