Ldelossa/srv6 monitor logging #30154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only functions left in egress_policies.h are SRv6 related. Let's rename this to 'srv6.h' and update references to the old file name. Signed-off-by: ldelossa <louis.delos@gmail.com>
Include a trace reason for SRv6 encapsulation and decapsulation. This greatly improves the debugging process, indicating whether SRv6 VPN related packets are processed by our datapath. Signed-off-by: ldelossa <louis.delos@gmail.com>
|
/test |
gentoo-root
approved these changes
Jan 9, 2024
YutaroHayakawa
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Changes looks good to me, but in addition to this, can't we contain the information about the SID on the header we decapsulated? So that we can answer to the question like "is SID X correctly decapsulated?". Looks like send_trace_notify6 can take an "orig_addr". Can't we use it to store SID?
|
Also, let me pull-in Hubble team as we touched to the trace_reason. |
@YutaroHayakawa I avoided doing this because we'd need to validate the skb_buff and pull out the ipv6 header when the tail call started, and then log it before we work on the sk_buff directly in |
|
Alright, then, for the moment, let's go with this. |
YutaroHayakawa
approved these changes
Jan 12, 2024
|
@YutaroHayakawa sounds good Yutaro. We could also add a raw cilium_dbg statement to dump the SID before we encap, therefore it doesn't 'suggest' anything in a follow up? |
|
Marking 'do-not-merge' until Alex has a chance to review. Talked with him and there maybe an implication to this in the Hubble code's ability to perform conn tracking observability. |
Consider encap/decap as egress/ingress (respectively) and both as unknown reply ct status. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
|
@gandro could you please take a look at the patch, especially the Hubble related commit 🙏 |
gandro
approved these changes
Jan 17, 2024
kaworu
approved these changes
Jan 17, 2024
|
/test |
1 task
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Mar 6, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Mar 7, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Mar 27, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 10, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 19, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 19, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 22, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 23, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 26, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
kaworu
added a commit
to kaworu/cilium
that referenced
this pull request
Apr 30, 2024
cilium#30154 and cilium#31073 introduced new datapath trace reasons and had an impact on Hubble, but the sig-hubble team doesn't get automatically pulled in for review. This patch adds the sig-hubble team to review datapath_trace.go changes. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames "egress_policies.h" to "srv6.h" since only SRv6 related logic was left in this file.
Moving forward "srv6.h" will be the canonical file for SRv6 related datapath functionality.
This PR also adds "srv6-encap" and "srv6-decap" monitor events, explaining to a debugger that SRv6 encap/decap successfully occurred and the subsequent packet is heading to the stack.
This will cut down the time it takes to debug whether the SRv6 datapath processed an SRv6 VPN related packet.