vendor: replace 2 unmaintained dependencies with their blessed forks #30028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c2a2b5 to
1c7c2d5
Compare
|
/test |
sayboras
reviewed
Dec 22, 2023
There was a problem hiding this comment.
The changes are looking innocent enough, however integration test failure is due to the recent upstream patch
level=error msg="Invoke failed" ="tables_test.fixture.func1 (pkg/datapath/tables/node_address_test.go:460)" error="could not build arguments for function \"github.com/cilium/cilium/pkg/datapath/tables_test\".fixture.func1 (/home/runner/work/cilium/cilium/pkg/datapath/tables/node_address_test.go:460): failed to build statedb.Table[github.com/cilium/cilium/pkg/datapath/tables.NodeAddress]: could not build arguments for function \"github.com/cilium/cilium/pkg/datapath/tables\".newNodeAddressController (/home/runner/work/cilium/cilium/pkg/datapath/tables/node_address.go:195): failed to build tables.NodeAddressConfig: received non-nil error from function \"github.com/cilium/cilium/pkg/hive/cell\".(*config[...]).Apply.func2 (/home/runner/work/cilium/cilium/pkg/hive/cell/config.go:154): failed to unmarshal config struct tables.NodeAddressConfig: 1 error(s) decoding:\n\n* error decoding 'nodeport-addresses[0]': invalid CIDR address: 2001::/16,10.0.0.0/8.\nHint: field 'FooBar' matches flag 'foo-bar', or use tag `mapstructure:\"flag-name\"` to match field with flag" subsys=hive
pippolo84
approved these changes
Dec 22, 2023
pippolo84
reviewed
Dec 22, 2023
chancez
approved these changes
Jan 2, 2024
bimmlerd
approved these changes
Jan 3, 2024
1c7c2d5 to
4edb59b
Compare
|
This pull request has been automatically marked as stale because it |
Mitchell Hashimoto has announced that he'll be archiving his Go repositories in early 2024. Switch mapstructure to using his "blessed fork". Ref: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Mitchell Hashimoto has announced that he'll be archiving his Go repositories in early 2024. Switch to using the "blessed fork" for protoc-gen-go-json. Ref: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
4edb59b to
7c35d02
Compare
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
|
This pull request has been automatically marked as stale because it |
|
This pull request has not seen any activity since it was marked stale. |
|
Replaced by #32739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitchell Hashimoto has announced that he'll be archiving his Go repositories in early 2024.
This PR updates 2 of these dependencies with their blessed forks.