Makefile: Refactor hubble-relay target #29867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de9e953 to
0a00f42
Compare
michi-covalent
approved these changes
Dec 13, 2023
|
https://github.com/cilium/cilium/actions/runs/7200060957/job/19613145935?pr=29867 looks like a legitimate failure |
Instead of using a fixed directory, use a variable to define the hubble-relay directory, just like the other cilium binaries. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
0a00f42 to
4d7ec47
Compare
|
Yup, looks like bash completion failed because we're cross compiling for alternative arches, meaning we can't execute the arm64 binary on an amd64 docker builder to generate bash completion. I updated it to skip the bash completion and just install the binary in the container. |
|
/test |
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a fixed directory, use a variable to define the hubble-relay directory, just like the other cilium binaries.
This is the same approach taken in 7310f52.