Skip to content

bpf, ipcache: Add skip_tunnel field to remote_endpoint_info #29796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

bpf, ipcache: Add skip_tunnel field to remote_endpoint_info #29796

merged 1 commit into from
Jan 16, 2024

Conversation

learnitall
Copy link
Contributor

@learnitall learnitall commented Dec 11, 2023 •
edited
Loading

Consume 8 bits of padding from the ipcache remote_endpoint_info struct and reserve them for optional flags. This commit adds a single new flag, flag_skip_tunnel, to signal that the attached endpoint shall not be forwarded through a VXLAN/Geneve tunnel, regardless of the Cilium configuration.

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
Add a new flag to endpoints in the IPCache to allow for overriding tunnel configuration

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 11, 2023
@learnitall learnitall force-pushed the pr/learnitall/add-skip-tunnel-field branch 6 times, most recently from 458fc68 to f5d9367 Compare December 12, 2023 20:46
@learnitall learnitall force-pushed the pr/learnitall/add-skip-tunnel-field branch from f5d9367 to 458679b Compare January 8, 2024 23:06
@learnitall learnitall added the release-note/misc This PR makes changes that have no direct user impact. label Jan 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 8, 2024
@learnitall learnitall added the area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Jan 9, 2024
@learnitall learnitall marked this pull request as ready for review January 9, 2024 00:24
@learnitall learnitall requested a review from a team as a code owner January 9, 2024 00:24
@learnitall learnitall requested a review from aspsk January 9, 2024 00:24
jschwinger233
jschwinger233 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jschwinger233 jschwinger233 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No issue for now, but I might be concerned about cilium upgrade, as the remote_endpoint_info->flag_skip_tunnel will be 0 after bpf map migration.

@learnitall @giorio94
bpf, ipcache: Add flag_skip_tunnel field to remote_endpoint_info
088c4c6 
Consume 8 bits of padding from the ipcache remote_endpoint_info
struct and reserve them for optional flags. This commit adds a
single new flag, `flag_skip_tunnel`, to signal that the attached
endpoint shall not be forwarded through a VXLAN/Geneve tunnel,
regardless of the Cilium configuration.

Co-authored-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
@learnitall learnitall force-pushed the pr/learnitall/add-skip-tunnel-field branch from 458679b to 088c4c6 Compare January 16, 2024 16:43
aspsk
aspsk approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@learnitall
Copy link
Contributor Author

/test

This was referenced Jan 16, 2024
Closed
Closed
Closed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 16, 2024
@michi-covalent michi-covalent added this pull request to the merge queue Jan 16, 2024
Merged via the queue into cilium:main with commit d9be0a0 Jan 16, 2024
@pchaigno
Copy link
Member

pchaigno commented Dec 5, 2024

The why is missing from both the commit and PR descriptions. What was the use case here?

@dylandreimerink dylandreimerink mentioned this pull request Jan 21, 2025
Merged
tommasopozzetti added a commit to tommasopozzetti/cilium that referenced this pull request Jan 24, 2025
@tommasopozzetti
Fix NodePort traffic to host netns backends with Geneve+DSR
bf84421 
Always set tunnel_endpoint in ipcache, even for directly reachable
endpoints. This ensures DSR info is available for DSR with geneve
dispatch.
Add plumbing to set and propagate endpointFlags from cilium#29796.
Use endpointFlags to set the skiptunnel flag for directly reachable
endpoints such that, even if overlay is enabled, we do not do
an unneeded encap.

Fixes: cilium#36901

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
tommasopozzetti added a commit to tommasopozzetti/cilium that referenced this pull request Jan 28, 2025
@tommasopozzetti
Add plumbing to set and propagate endpointFlags from cilium#29796
a465cb6 
This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
tommasopozzetti added a commit to tommasopozzetti/cilium that referenced this pull request Jan 28, 2025
@tommasopozzetti
Add plumbing to set and propagate endpointFlags from cilium#29796
78204d8 
This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
tommasopozzetti added a commit to tommasopozzetti/cilium that referenced this pull request Feb 5, 2025
@tommasopozzetti
Add plumbing to set and propagate endpointFlags from cilium#29796
225b859 
This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
github-merge-queue bot pushed a commit that referenced this pull request Feb 10, 2025
@tommasopozzetti @joestringer
Add plumbing to set and propagate endpointFlags from #29796
9715b5c 
This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
jongj pushed a commit to jongj/cilium that referenced this pull request Feb 11, 2025
@tommasopozzetti @jongj
Add plumbing to set and propagate endpointFlags from cilium#29796
bde354c 
This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
nbusseneau pushed a commit that referenced this pull request Feb 14, 2025
@tommasopozzetti @nbusseneau
Add plumbing to set and propagate endpointFlags from #29796
f831ffa 
[ upstream commit 9715b5c ]

This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau pushed a commit that referenced this pull request Feb 14, 2025
@tommasopozzetti @nbusseneau
Add plumbing to set and propagate endpointFlags from #29796
2f484e9 
[ upstream commit 9715b5c ]

This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau pushed a commit that referenced this pull request Feb 14, 2025
@tommasopozzetti @nbusseneau
Add plumbing to set and propagate endpointFlags from #29796
bfbc9b9 
[ upstream commit 9715b5c ]

This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2025
@tommasopozzetti @michi-covalent
Add plumbing to set and propagate endpointFlags from #29796
b961996 
[ upstream commit 9715b5c ]

This commit makes endpoint flags available for plumbing in the new
ipcache API, allowing to set them from higher in the stack

Signed-off-by: Tommaso Pozzetti <tommypozzetti@hotmail.it>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
julianwiedmann added a commit that referenced this pull request Mar 9, 2025
@julianwiedmann
Revert "Add plumbing to set and propagate endpointFlags from #29796"
776cab0 
This reverts commit b961996.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 11, 2025
@julianwiedmann @dylandreimerink
Revert "Add plumbing to set and propagate endpointFlags from #29796"
3864540 
This reverts commit b961996.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
brb added a commit that referenced this pull request May 5, 2025
@brb
Revert "Add plumbing to set and propagate endpointFlags from #29796"
18e7350 
This reverts commit 9715b5c.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
brb added a commit that referenced this pull request May 5, 2025
@brb
Revert "Add plumbing to set and propagate endpointFlags from #29796"
cb09e3f 
This reverts commit 9715b5c.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
brb added a commit that referenced this pull request May 5, 2025
@brb
Revert "Add plumbing to set and propagate endpointFlags from #29796"
3555a39 
This reverts commit 9715b5c.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
brb added a commit that referenced this pull request May 5, 2025
@brb
Revert "Add plumbing to set and propagate endpointFlags from #29796"
b22a8ba 
This reverts commit 9715b5c.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
brb added a commit that referenced this pull request May 5, 2025
@brb
Revert "Add plumbing to set and propagate endpointFlags from #29796"
c876b93 
This reverts commit 9715b5c.

Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
@kvaps kvaps mentioned this pull request Aug 25, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@learnitall @pchaigno @aspsk @jschwinger233 @michi-covalent