Skip to content

workflows: Make the conn-disrupt test more sensitive #29623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2023
Merged

workflows: Make the conn-disrupt test more sensitive #29623

merged 1 commit into from
Dec 6, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Dec 5, 2023 •
edited
Loading

By reducing the interval between two sent packets to 0ms, we are making the conn-disrupt test more sensitive to drops. That should help us identify remaining bugs in upgrades, key rotations, etc.

Fixes: #27916.

@pchaigno pchaigno added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. needs-backport/1.12 labels Dec 5, 2023
@pchaigno
workflows: Make the conn-disrupt test more sensitive
30b9e00 
By reducing the interval between two sent packets to 0ms, we are making
the conn-disrupt test more sensitive to drops. That should help us
identify remaining bugs in upgrades, key rotations, etc.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the pr/pchaigno/more-sensitive-conn-disrupt-test branch from 83d6de2 to 30b9e00 Compare December 6, 2023 09:36
@pchaigno
Copy link
Member Author

pchaigno commented Dec 6, 2023

/test

@pchaigno pchaigno requested a review from brb December 6, 2023 09:54
@pchaigno pchaigno marked this pull request as ready for review December 6, 2023 09:54
@pchaigno pchaigno requested review from a team as code owners December 6, 2023 09:54
@pchaigno pchaigno requested a review from brlbil December 6, 2023 09:54
brb
brb approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Completely forgot about it. I will set the default in the CLI to 0ms too.

@brb
Copy link
Member

brb commented Dec 6, 2023

cilium/cilium-cli#2156

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 6, 2023
@pchaigno pchaigno added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 13efef3 Dec 6, 2023
@pchaigno pchaigno deleted the pr/pchaigno/more-sensitive-conn-disrupt-test branch December 6, 2023 11:07
@nbusseneau
Copy link
Member

@pchaigno Doing backports right now: this PR makes changes to tests-clustermesh-upgrade.yaml on parts introduced in #27232, which was not backported to stable branches. I am electing to ignore them and simply apply --conn-disrupt-dispatch-interval 0ms to any conn-disrupt test that exist currently in stable branches, please yell if that's not fine.

@nbusseneau nbusseneau mentioned this pull request Dec 7, 2023
Merged
2 tasks
@nbusseneau nbusseneau mentioned this pull request Dec 7, 2023
Merged
2 tasks
@nbusseneau nbusseneau mentioned this pull request Dec 7, 2023
Merged
3 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Dec 7, 2023
@pchaigno
Copy link
Member Author

pchaigno commented Dec 7, 2023

@pchaigno Doing backports right now: this PR makes changes to tests-clustermesh-upgrade.yaml on parts introduced in #27232, which was not backported to stable branches. I am electing to ignore them and simply apply --conn-disrupt-dispatch-interval 0ms to any conn-disrupt test that exist currently in stable branches, please yell if that's not fine.

I think that's the right resolution.

@pchaigno pchaigno mentioned this pull request Dec 7, 2023
Merged
@nebril nebril added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 labels Dec 11, 2023
@joestringer joestringer mentioned this pull request Dec 14, 2023
Merged
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 labels Dec 14, 2023
This was referenced Jan 17, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@brlbil brlbil brlbil approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
cilium v1.12.18
Status: Released
cilium v1.13.11
Status: Released
cilium v1.14.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the migrate-svc app we use in ipsec tests more sensitive to drops
5 participants
@pchaigno @brb @nbusseneau @brlbil @nebril