Skip to content

cilium: Add a few bwm setting tweaks #29552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2023
Merged

cilium: Add a few bwm setting tweaks #29552

merged 3 commits into from
Dec 1, 2023

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Dec 1, 2023

(see commit desc)

@borkmann borkmann added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/bandwidth-manager Impacts BPF bandwidth manager. labels Dec 1, 2023
@borkmann borkmann requested review from a team as code owners December 1, 2023 14:14
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 1, 2023
@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Dec 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2023
@borkmann borkmann requested a review from aspsk December 1, 2023 14:16
@borkmann borkmann force-pushed the pr/bwm-tweaks branch 2 times, most recently from d769206 to 125dfbc Compare December 1, 2023 14:31
@borkmann
Copy link
Member Author

borkmann commented Dec 1, 2023

/test

aspsk
aspsk approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small typo: Slighly -> Slightly in commit 2 message header

@borkmann
Copy link
Member Author

borkmann commented Dec 1, 2023

/test

qmonnet
qmonnet approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@qmonnet qmonnet removed the request for review from learnitall December 1, 2023 15:20
rolinh
rolinh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor changes lgtm

@qmonnet qmonnet removed the request for review from markpash December 1, 2023 15:50
@borkmann
vendor: Update vishvananda/netlink/
9079966 
Pull in recent additions to the netlink go library, that is, support
for setting TCA_FQ_PLIMIT and managing netkit driver (future work).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: vishvananda/netlink#929
Link: vishvananda/netlink#930
@borkmann
cilium: Slightly tweak bwm parameters
439e9b2 
Align the qdisc drop horizon with the one we use in our BPF code, and
also bump the buckets_log given they can potentially cause scalability
issue. The rest remains with the defaults.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
cilium: Update bwm doc with note about bpf host routing
d80a4ee 
Update the doc with a note that it is strongly recommended to use it
only in combination with BPF host routing.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

borkmann commented Dec 1, 2023

(rebase to latest main to bring in ci fixes, rest unchanged)

@borkmann
Copy link
Member Author

borkmann commented Dec 1, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2023
@borkmann borkmann added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 995cc1f Dec 1, 2023
@borkmann borkmann deleted the pr/bwm-tweaks branch December 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@aspsk aspsk aspsk approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. feature/bandwidth-manager Impacts BPF bandwidth manager. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@borkmann @rolinh @aspsk @qmonnet