ci: increase cilium wait timeout to 10m on cloud providers #29541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where image pulling isn't successful within 5 minutes (default wait time of `cilium status --wait`). Especially on public cloud providers, it might takes longer in some cases. Therefore, this commit increases the wait timeout to 10m. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
brb
approved these changes
Dec 1, 2023
I'd wait to see whether this change helps at all (image pull finishes or makes a retry within the +5min). If we realize that there are new cases where we hit the overall timeout (due to cases where we spend more time in the cilium wait) we can start to bump the job timeout. |
|
/test |
brlbil
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where image pulling isn't successful within 5 minutes (default wait time of
cilium status --wait).Especially on public cloud providers, it might takes longer in some cases.
What's interesting, it's never a >=1.27 k8s cluster. Good indication that parallel image pull introduced with 1.27 will help here: https://kubernetes.io/blog/2023/05/15/speed-up-pod-startup/
Therefore, this commit increases the wait timeout to 10m.
I'm aware that this might introduce follow up issues (due to overall timeout) if more time is spent in this wait. But would be interesting to know if this helps.