ci: don't write github commit status on push event #29438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
reviewed
Nov 28, 2023
Currently, some GitHub workflows are reporting back their status via GitHub Commit Status. The main reason is to link the status of the workflow run to a specific commit SHA. This is necessary for workflows that are triggered via Ariane (trigger `workflows_dispatch`). However, if the same workflow is triggered via `push` (e.g. after a PR being merged), reporting the status via commit status is unnecessary, as the workflow is already linked to the correct commit SHA. Therefore, this commit suppresses the commit status reporting in case of a `push` trigger. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
22e45cd to
4da2e0e
Compare
|
/test |
aanm
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some GitHub workflows are reporting back their status via GitHub Commit Status. The main reason is to link the status of the workflow run to a specific commit SHA. This is necessary for workflows that are triggered via Ariane (trigger
workflows_dispatch).However, if the same workflow is triggered via
push(e.g. after a PR being merged), reporting the status via commit status is unnecessary, as the workflow is already linked to the correct commit SHA.Therefore, this commit suppresses the commit status reporting in case of a
pushtrigger.Fixes: #29404