Skip to content

ci-e2e-upgrade: Remove setting CLI vsn #29435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

ci-e2e-upgrade: Remove setting CLI vsn #29435

merged 1 commit into from
Dec 1, 2023

Conversation

brb
Copy link
Member

@brb brb commented Nov 28, 2023

It's controlled by set-env-variables.

@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 28, 2023
@brb
Copy link
Member Author

brb commented Nov 28, 2023

/test

@brb
Copy link
Member Author

brb commented Nov 28, 2023

Blocked by cilium/cilium-cli#2129.

@brb
Copy link
Member Author

brb commented Nov 29, 2023

/test

@brb brb changed the title gh/workflows: Bump CLI to v0.15.15 ci-e2e-upgrade: Remove setting CLI vsn Nov 29, 2023
@brb
Copy link
Member Author

brb commented Nov 29, 2023

/ci-e2e-upgrade

@brb brb marked this pull request as ready for review November 29, 2023 06:36
@brb brb requested review from a team as code owners November 29, 2023 06:36
@brb brb requested a review from brlbil November 29, 2023 06:36
@brb
Copy link
Member Author

brb commented Nov 29, 2023

/ci-e2e-upgrade

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2023
@brb brb enabled auto-merge November 29, 2023 08:44
@@ -52,7 +52,6 @@ concurrency:

env:
# renovate: datasource=github-releases depName=cilium/cilium-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove this line as well

@aanm aanm removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2023
It's controlled by set-env-variables.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb requested a review from aanm November 30, 2023 05:26
@brb brb disabled auto-merge December 1, 2023 10:05
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2023
@aanm aanm enabled auto-merge December 1, 2023 13:38
@aanm aanm disabled auto-merge December 1, 2023 13:46
@aanm aanm merged commit 93a71f5 into main Dec 1, 2023
@aanm aanm deleted the pr/brb/bump-cli branch December 1, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants