Skip to content

Conversation

mhofstetter
Copy link
Member

Currently, the following GitHub workflows are only executed on a scheduled basis.

These tests are quite stable, don't depend on public cloud infra, don't use special runners and finish within a reasonable time.

Therefore, this PR changes this that the workflows are executed after every merge of a PR (trigger push).

The reasons are:

  • Align these workflows with other workflows
  • Provide better and faster correlation with the respective pull
    request that introduced a change.

@mhofstetter mhofstetter added area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI. labels Nov 28, 2023
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review November 28, 2023 09:58
@mhofstetter mhofstetter requested review from a team as code owners November 28, 2023 09:58
@mhofstetter mhofstetter requested a review from brlbil November 28, 2023 09:58
Currently, Clustermesh related GitHub workflows are only executed
on a scheduled basis.

This commit changes this that the workflows are executed after every
merge of a PR (trigger `push`).

The reasons are:
* Align these workflows with other workflows
* Provide better and faster correlation with the respective pull
request that introduced a change.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, the Multi Pool IPAM GitHub workflow is only executed
on a scheduled basis.

This commit changes this that the workflows are executed after every
merge of a PR (trigger `push`).

The reasons are:
* Align these workflows with other workflows
* Provide better and faster correlation with the respective pull
  request that introduced a change.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, the cyclonus Network Policy related GitHub workflow is only executed
on a scheduled basis.

This commit changes this that the workflows are executed after every
merge of a PR (trigger `push`).

The reasons are:
* Align these workflows with other workflows
* Provide better and faster correlation with the respective pull
  request that introduced a change.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, the L4LB XDP related GitHub workflow is only executed
on a scheduled basis.

This commit changes this that the workflows are executed after every
merge of a PR (trigger `push`).

The reasons are:
* Align these workflows with other workflows
* Provide better and faster correlation with the respective pull
  request that introduced a change.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/gha-schedule-to-push branch from 0b7fef1 to ddb4ab8 Compare November 28, 2023 11:47
@mhofstetter
Copy link
Member Author

/test

Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this was something on my TODO list 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2023
@aanm aanm added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit a838647 Nov 28, 2023
@aanm aanm deleted the pr/mhofstetter/gha-schedule-to-push branch November 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants