.github/workflows: only cancel concurrent jobs if not in merge_group #29431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we cancel concurrent jobs, regardless of them being in merge_group or not, we will not be able to have concurrent runs for the same workflow in the merge groups events. Thus, we should detect if the event is not from a merge_group and only cancel the concurrent jobs on that case. Signed-off-by: André Martins <andre@cilium.io>
|
/test |
viktor-kurchenko
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cancel concurrent jobs, regardless of them being in merge_group or not, we will not be able to have concurrent runs for the same workflow in the merge groups events. Thus, we should detect if the event is not from a merge_group and only cancel the concurrent jobs on that case.