ci: fix deployment issue with multiple clusters in same region #29427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the tests `ci-eks` & `ci-aws-cni` fail due to issues deploying multiple clusters with the same name in the same region. Therefore, this commit uses a different region for k8s version v1.24 to ensure that only one cluster gets deployed per region. Fixes: cilium#29004 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
|
/test |
nickolaev
approved these changes
Nov 28, 2023
|
Nice find!
@mhofstetter Could you create a GH issue? 🍕 |
brb
approved these changes
Nov 28, 2023
sayboras
approved these changes
Nov 28, 2023
|
@mhofstetter Do we need to backport it to stable branches? |
Already there: #29426
IMO this should not be necessary as long as the PR introducing the overlapping clusters in the same region #29004 doesn't get backported. |
Your "Fixes" comment in the PR description will close it. |
Yep, I reopened it with a comment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tests
ci-eks&ci-aws-cnifail due to issues deploying multiple clusters with the same name in the same region.Therefore, this commit uses a different region for k8s version v1.24 to ensure that only one cluster gets deployed per region.
Note: This is the quick fix. As mentioned in the related issue, it might be better to ensure a unique name via other measures.
Fixes: #29004
Fixes: #29426