ci aws: cleanup EKS cluster in separate job #29412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef9f9aa to
84d1185
Compare
|
/test |
Currently, deleting an AWS EKS cluster takes quite some time to await the deletion of the corresponding CloudFormation stack (~7min). Unfortunately, even if the flag `wait` isn't set. This delayes reporting the status of the tests respectively. Therefore, this commit moves the cleanup of the AWSK EKS clusters into its own job - after the job that reports the status via GitHub commit status. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
84d1185 to
2804ecc
Compare
|
/test |
aanm
approved these changes
Nov 28, 2023
nbusseneau
approved these changes
Nov 28, 2023
|
Good idea, the additional boilerplate is worth it in this case I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, deleting an AWS EKS cluster takes quite some time to await the deletion of the corresponding CloudFormation stack (~7-10min). Unfortunately, even if the flag
waitisn't set.This delayes reporting the status of the tests respectively.
Therefore, this commit moves the cleanup of the AWS EKS clusters into its own job - after the job that reports the status via GitHub commit status.