Skip to content

probes: remove HAVE_FIB_LOOKUP leftovers #29401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2023
Merged

probes: remove HAVE_FIB_LOOKUP leftovers #29401

merged 2 commits into from
Nov 29, 2023

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Nov 27, 2023

As a follow-up to #29348, this PR removes leftovers related to HAVE_FIB_LOOKUP.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2023
@rgo3 rgo3 added area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Nov 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2023
@rgo3
Copy link
Contributor Author

rgo3 commented Nov 27, 2023

/test

julianwiedmann
julianwiedmann reviewed Nov 27, 2023
View reviewed changes
@rgo3 rgo3 force-pushed the remove-fib-lookup-leftovers branch from 3c105b4 to 7fb6f7b Compare November 27, 2023 13:30
@rgo3
Copy link
Contributor Author

rgo3 commented Nov 27, 2023

Rebased on top of #29377 to avoid causing unnecessary git conflicts for that PR and not leaving empty function stubs around for the xdp-specifc feature header generation. Waiting for #29377 to go in first.

@rgo3 rgo3 added the dont-merge/blocked Another PR must be merged before this one. label Nov 27, 2023
@rgo3 rgo3 force-pushed the remove-fib-lookup-leftovers branch from 7fb6f7b to e2f1f88 Compare November 27, 2023 17:45
rgo3 added 2 commits November 28, 2023 14:16
@rgo3
probes: rename header generation test input string
9602adb 
This commit renames the test input for the feature header generation
test from HAVE_FIB_LOOKUP to HAVE_FEATURE_MACRO.

This is in prepation of a following commit where we remove the probing
for HAVE_FIB_LOOKUP as it is no longer needed. HAVE_FEATURE_MACRO is
test-specific and will not show up when grepping for other feature
macros that are in use in the code base.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3
probes: remove HAVE_FIB_LOOKUP leftovers
315d25a 
As a follow-up to cilium#29348, this commit removes probes and feature header
generation related to HAVE_FIB_LOOKUP.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3 rgo3 force-pushed the remove-fib-lookup-leftovers branch from e2f1f88 to 315d25a Compare November 28, 2023 13:17
@rgo3
Copy link
Contributor Author

rgo3 commented Nov 28, 2023

/test

@rgo3 rgo3 removed the dont-merge/blocked Another PR must be merged before this one. label Nov 28, 2023
@rgo3 rgo3 marked this pull request as ready for review November 29, 2023 08:30
@rgo3 rgo3 requested a review from a team as a code owner November 29, 2023 08:30
@rgo3 rgo3 requested a review from ti-mo November 29, 2023 08:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2023
@ti-mo ti-mo added this pull request to the merge queue Nov 29, 2023
Merged via the queue into cilium:main with commit 82dbff8 Nov 29, 2023
@ti-mo ti-mo deleted the remove-fib-lookup-leftovers branch November 29, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann left review comments

@ti-mo ti-mo ti-mo approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgo3 @ti-mo @julianwiedmann