Skip to content

gh/workflows: Add lvh-kind action and use it in ci-e2e #29485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2023
Merged

gh/workflows: Add lvh-kind action and use it in ci-e2e #29485

merged 3 commits into from
Dec 1, 2023

Conversation

brb
Copy link
Member

@brb brb commented Nov 29, 2023 •
edited
Loading

This will allow us to create more reusable workflows for testing. E.g., ci-ipsec-e2e will be reused by ci-eks, ci-aks, etc.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2023
@brb
Copy link
Member Author

brb commented Nov 29, 2023

/ci-e2e

@brb
Copy link
Member Author

brb commented Nov 29, 2023

/ci-e2e

@brb brb changed the title WIP: lvh-kind + ci-e2e gh/workflows: Add lvh-kind action and use it in ci-e2e Nov 30, 2023
@brb
Copy link
Member Author

brb commented Nov 30, 2023

/ci-e2e

@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. needs-backport/1.12 backport/author The backport will be carried out by the author of the PR. labels Nov 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 30, 2023
@brb
Copy link
Member Author

brb commented Nov 30, 2023

/ci-e2e

@brb brb marked this pull request as ready for review November 30, 2023 08:33
@brb brb requested review from a team as code owners November 30, 2023 08:33
jschwinger233
jschwinger233 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jschwinger233 jschwinger233 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

qmonnet
qmonnet approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Few comments/questions, but nothing blocking.

brb added 3 commits November 30, 2023 16:34
@brb
kind.sh: Allow to specify apiServer addr + port
be101ad 
This is going to be used when exposing a K8s cluster in a LVH VM to its
hypervisor host ("0.0.0.0:6443").

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
gh/workflows: Add lvh-kind action
5253f2d 
The action provisions K8s cluster on LVH VM, and then exposes it to GHA
runner.

With this action we will be able to run kubectl / cilium / etc commands
directly from GHA runner instead of SSH'ing into VM.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
ci-e2e: Use lvh-kind action instead of c/little-vm-helper
0b1daa1 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
Copy link
Member Author

brb commented Nov 30, 2023

/ci-e2e

viktor-kurchenko
viktor-kurchenko approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 30, 2023
@aanm
Copy link
Member

aanm commented Nov 30, 2023

/test

@aanm aanm enabled auto-merge November 30, 2023 16:17
@aanm aanm added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 936c8ae Dec 1, 2023
@aanm aanm deleted the pr/brb/lvh-kind branch December 1, 2023 13:35
@qmonnet qmonnet mentioned this pull request Dec 18, 2023
Merged
3 tasks
@qmonnet qmonnet added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Dec 18, 2023
@qmonnet qmonnet mentioned this pull request Dec 20, 2023
Merged
5 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 21, 2023
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels Jan 11, 2024
This was referenced Jan 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@nebril nebril nebril approved these changes

@jschwinger233 jschwinger233 jschwinger233 approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport/author The backport will be carried out by the author of the PR. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
cilium v1.13.11
Status: Released
cilium v1.14.6
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brb @aanm @nebril @jschwinger233 @qmonnet @viktor-kurchenko @julianwiedmann