datapath: Fix primary flag in NodeAddress #29483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
848dfc1 to
60926d7
Compare
bimmlerd
reviewed
Nov 29, 2023
60926d7 to
86a0182
Compare
|
/test |
bimmlerd
reviewed
Nov 30, 2023
Since the "NodePort" and "Primary" flag computation is mixed together we should do it for non-selected devices as well, so mark address for NodePort use only if the device is selected. Additionally, only consider addresses on selected devices when filtering with --nodeport-addresses. Simplify the special-handling for the addresses of cilium_host by just adjusting the maximum scope. Finally add an assertion to tests to check that primary is correctly set. Fixes: 5342d01 ("datapath/tables: Add Table[NodeAddress]") Signed-off-by: Jussi Maki <jussi@isovalent.com>
86a0182 to
0be3fc0
Compare
dylandreimerink
approved these changes
Dec 1, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the "NodePort" and "Primary" flag computation is mixed together we should do it for non-selected devices as well, so mark address for NodePort use only if the device is selected.
Additionally, only consider addresses on selected devices when filtering with --nodeport-addresses.
Simplify the special-handling for the addresses of cilium_host by just adjusting the maximum scope.
Finally add an assertion to tests to check that primary is correctly set.