mountinfo: fix build on linux/386 #29481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Due to a recent change cilium-cli started pulling in this package.
We currently still build release binaries for linux/386, but these are
failing with
# github.com/cilium/cilium/pkg/mountinfo
Error: ../../pkg/mountinfo/mountinfo_linux.go:56:27: invalid operation: fst.Type == mntType (mismatched types int32 and int64)
because fst.Type has a different type depending on GOARCH (e.g. int32 on
linux/386). Fix this issue by converting fst.Type to int64 for
comparison.
Related #16843
Signed-off-by: Tobias Klauser <tobias@cilium.io>
33e9521 to
632510f
Compare
|
/test |
borkmann
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent change cilium-cli started pulling in this package. We currently still build release binaries for linux/386, but these are failing with
because fst.Type has a different type depending on GOARCH (e.g. int32 on linux/386). Fix this issue by converting fst.Type to int64 for comparison.
Related #16843