Skip to content

Conversation

123MwanjeMike
Copy link
Contributor

@123MwanjeMike 123MwanjeMike commented Nov 28, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Adds @airqo-platform to list of users

Signed-off-by: Mike Mwanje <mwanjemike767@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 28, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 28, 2023
@123MwanjeMike 123MwanjeMike marked this pull request as ready for review November 28, 2023 22:51
@123MwanjeMike 123MwanjeMike requested a review from a team as a code owner November 28, 2023 22:51
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Nov 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2023
@xmulligan
Copy link
Member

Thanks for the addition!

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2023
@maintainer-s-little-helper
Copy link

Commit dd5cb2f does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Nov 29, 2023
@aanm aanm merged commit 873a0d2 into cilium:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants