plugins/cilium-cni: Install loopback atomically #29462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If copying of the loopback binary is interrupted, then a truncated
version will exist on the node. The node can't recover from this state
even if the pod is restarted because install-plugin.sh won't overwrite
the existing loopback file.
To fix, install loopback atomically using a cp + mv.
This change also removes the unnecessary deletion of "${BIN_NAME}.new".
This is a no-op because the temporary copy destination is prefixed with
a dot: ".${BIN_NAME}.new".
Signed-off-by: Akhil Velagapudi <4@4khil.com>
|
/test |
|
Any chance this can be back-ported to v1.12+ as it's a bug fix? We actually encountered this issue in v1.12. |
aanm
approved these changes
Nov 29, 2023
@akhilles According the backports criteria, 1.12 would security related bug fixes. We can mark it for 1.14. |
10 tasks
skmatti
pushed a commit
to skmatti/cilium
that referenced
this pull request
Jul 24, 2024
If copying of the loopback binary is interrupted, then a truncated
version will exist on the node. The node can't recover from this state
even if the pod is restarted because install-plugin.sh won't overwrite
the existing loopback file.
To fix, install loopback atomically using a cp + mv.
This change also removes the unnecessary deletion of "${BIN_NAME}.new".
This is a no-op because the temporary copy destination is prefixed with
a dot: ".${BIN_NAME}.new".
Bug: b/310226307
Upstream-PR: cilium#29462
Change-Id: I24fddcc5e271063edf8f30ca58d8738c75af63df
Signed-off-by: Akhil Velagapudi <4@4khil.com>
Reviewed-on: https://gke-internal-review.googlesource.com/c/third_party/cilium/+/888710
Tested-by: Prow_Bot_V2 <425329972751-compute@developer.gserviceaccount.com>
Unit-Verified: Prow_Bot_V2 <425329972751-compute@developer.gserviceaccount.com>
Reviewed-by: Prow_Bot_V2 <425329972751-compute@developer.gserviceaccount.com>
Reviewed-by: Akhil Velagapudi <avelagap@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If copying of the loopback binary is interrupted, then a truncated version will exist on the node. The node can't recover from this state even if the pod is restarted because install-plugin.sh won't overwrite the existing loopback file.
To fix, install loopback atomically using a cp + mv.
This change also removes the unnecessary deletion of "${BIN_NAME}.new". This is a no-op because the temporary copy destination is prefixed with a dot: ".${BIN_NAME}.new".
Fixes: #29461