Skip to content

bpf: do not invoke llc from Makefiles #29459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2024
Merged

bpf: do not invoke llc from Makefiles #29459

merged 2 commits into from
Jan 3, 2024

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Nov 28, 2023

bpf: do not invoke llc separately

Update the various bpf Makefiles to not invoke llc anymore. This matches 
what the loader does now.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

tools/dev-doctor: do not check for llc

Compiling bpf doesn't invoke llc directly anymore, stop checking for its
presence.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

@lmb lmb added area/loader Impacts the loading of BPF programs into the kernel. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Nov 28, 2023
@lmb lmb mentioned this pull request Nov 28, 2023
Merged
@lmb lmb force-pushed the makefile-oneshot-compile branch from 0f72ad5 to d96507c Compare November 30, 2023 08:59
@lmb
Copy link
Contributor Author

lmb commented Nov 30, 2023

/test

@lmb
Copy link
Contributor Author

lmb commented Nov 30, 2023

Needs #29510

@aanm aanm added dont-merge/blocked Another PR must be merged before this one. dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs and removed dont-merge/blocked Another PR must be merged before this one. labels Dec 4, 2023
@lmb lmb force-pushed the makefile-oneshot-compile branch from d96507c to 6e6cd91 Compare December 5, 2023 09:45
@lmb lmb force-pushed the makefile-oneshot-compile branch from 6e6cd91 to f932a2f Compare December 14, 2023 09:42
@lmb
Copy link
Contributor Author

lmb commented Dec 14, 2023

/ci-verifier

@lmb lmb removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Dec 14, 2023
@lmb
Copy link
Contributor Author

lmb commented Dec 14, 2023

/test

@lmb lmb marked this pull request as ready for review December 14, 2023 09:54
@lmb lmb requested review from a team as code owners December 14, 2023 09:54
borkmann
borkmann reviewed Dec 14, 2023
View reviewed changes
@dylandreimerink dylandreimerink removed their request for review December 15, 2023 09:49
@lmb lmb force-pushed the makefile-oneshot-compile branch from f932a2f to ac5c5bc Compare December 15, 2023 12:07
@lmb lmb requested a review from borkmann December 15, 2023 12:08
lmb added 2 commits January 3, 2024 10:09
@lmb
bpf: do not invoke llc separately
12cfc8e 
Update the various bpf Makefiles to not invoke llc anymore. This matches
what the loader does now.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb
tools/dev-doctor: do not check for llc
f5e3913 
Compiling bpf doesn't invoke llc directly anymore, stop checking for its presence.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the makefile-oneshot-compile branch from ac5c5bc to f5e3913 Compare January 3, 2024 09:09
@lmb
Copy link
Contributor Author

lmb commented Jan 3, 2024

/test

dylandreimerink
dylandreimerink approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmb lmb enabled auto-merge January 3, 2024 10:22
@lmb lmb added this pull request to the merge queue Jan 3, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 3, 2024
Merged via the queue into cilium:main with commit ef54b49 Jan 3, 2024
@lmb lmb deleted the makefile-oneshot-compile branch January 3, 2024 11:11
@aanm aanm mentioned this pull request Oct 2, 2024
Merged
14 tasks
@aanm aanm added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Oct 2, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Oct 7, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Oct 9, 2024
Merged
@julianwiedmann julianwiedmann mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@joamaki joamaki joamaki approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@rgo3 rgo3 rgo3 approved these changes

Assignees
No one assigned
Labels
area/loader Impacts the loading of BPF programs into the kernel. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmb @borkmann @joamaki @dylandreimerink @bimmlerd @rgo3 @aanm