pkg/l2announcer: ensure leases are only created for services that are being announced #29446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
reviewed
Nov 29, 2023
|
Commit 4f3c0e6 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
4f3c0e6 to
26d1c28
Compare
|
Commit 4f3c0e6 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
26d1c28 to
528e994
Compare
youngnick
approved these changes
Nov 29, 2023
…nced Previously leases were created for all services in the cluster regardless of them having an announceable IP or not. This change ensures that these services are skipped and only services with an external and/or LB IP - depending on the policy - will have a lease. Fixes: cilium#28752 Signed-off-by: Filip Nikolic <oss.filipn@gmail.com>
528e994 to
b93f3e1
Compare
aspsk
approved these changes
Nov 30, 2023
|
/test |
dylandreimerink
approved these changes
Dec 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/l2announcer: ensure leases are only created for services that are being announced
Previously leases were created for all services in the cluster regardless of them having an announceable IP or not.
This change ensures that these services are skipped and only services with an external and/or LB IP - depending on the policy - will have a lease. Fixes: #28752