ci: fix merge group required checks #29337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 74f3fd3 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This commit removes merge_group trigger from tests-smoke-ipv6.yaml workflow and adds a condition for Installation and Conformance Test in tests-smoke.yaml not to run on merge_group events. These two tests require CI images and since merge_group creates a new branch with all other commits merged in the queue, SHA of the expected image is changed. Either we have to add Build Image CI to the required checks or disable these tests from running. Since Build Image CI takes a long time to run, on top of these two tests have to wait for the image to be available and run to completion. We implemented the second option. Signed-off-by: Birol Bilgin <birol@cilium.io>
74f3fd3 to
64ac1bd
Compare
|
/test |
aanm
approved these changes
Nov 22, 2023
nbusseneau
approved these changes
Nov 22, 2023
|
Failing tests are not related to the changes so setting as read to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes merge_group trigger from tests-smoke-ipv6.yaml workflow and adds a condition for
Installation and Conformance Testin tests-smoke.yaml not to run on merge_group events.These two tests require CI images and since merge_group creates a new branch with all other commits merged in the queue, SHA of the expected image is changed. Either we have to add Build Image CI to the required checks or disable these tests from running. Since Build Image CI takes a long time to run, on top of these two tests have to wait for the image to be available and run to completion. We implemented the second option.