plugins/cilium-cni: Move implementation into separate package #29336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased due to conflict on main. @nathanjsweet @tommyp1ckles Could I get a review on this? I'd like to merge this before the feature freeze in 3 days. |
This will be used for labels added by the CNI plugin. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit moves the files implementing the `cilium-cni` binary to a different directory and does not contain any functional changes. In the next commit, we will restructure the package and bring back the `plugins/main.go`. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This commit makes `plugins/cilium-cni/cmd` a proper package and moves the `main` entry point again back to it's original location. This will make it easier to re-use parts of the Cilium CNI plugin. Other than that, this commit contains no functional changes. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
efd5349 to
c0e2346
Compare
|
/test |
nathanjsweet
approved these changes
Nov 28, 2023
squeed
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
plugins/cilium-cnia proper Go package. This will make it easier to re-use parts of the Cilium CNI plugin out of tree. The first commit (which adds aCNIlabel source) is also done for that purpose. It already has been used by out-of-tree Cilium API users.Review per commit
This PR contains no functional changes, besides allowing CNI plugin modifications out-of-tree.