Skip to content

Clarify cilium_event_ts metric description #29303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2023
Merged

Clarify cilium_event_ts metric description #29303

merged 2 commits into from
Nov 23, 2023

Conversation

christarazi
Copy link
Member

  • metrics: Clarify cilium_event_ts metric description
  • docs: Add missing cilium_k8s_event_lag_seconds metric from reference

@christarazi christarazi requested a review from a team as a code owner November 21, 2023 03:34
@christarazi christarazi added kind/cleanup This includes no functional changes. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. labels Nov 21, 2023
@christarazi christarazi requested a review from a team as a code owner November 21, 2023 03:34
@christarazi christarazi added the release-note/misc This PR makes changes that have no direct user impact. label Nov 21, 2023
@christarazi christarazi requested a review from a team as a code owner November 21, 2023 03:34
@christarazi christarazi changed the title pr/christarazi/metrics eventts cleanup Clarify cilium_event_ts metric description Nov 21, 2023
@christarazi
metrics: Clarify cilium_event_ts metric description
409e0ed 
From the description, it was unclear what the metric was actually
tracking. Change it to make it clearer that the metric tracks the latest
timestamp for an event, based on where the event came from (source), the
resource of the event, i.e. CiliumEndpoint, and what the action was,
i.e. created or deleted, etc.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
docs: Add missing cilium_k8s_event_lag_seconds metric from reference
44350f4 
The metric is currently disabled by default.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/metrics-eventts-cleanup branch from 11bf7f2 to 44350f4 Compare November 21, 2023 03:37
@christarazi
Copy link
Member Author

christarazi commented Nov 21, 2023 •
edited
Loading

/test

Edit:

qmonnet
qmonnet reviewed Nov 21, 2023
View reviewed changes
@christarazi
Copy link
Member Author

/ci-clustermesh

@christarazi
Copy link
Member Author

/ci-external-workloads

qmonnet
qmonnet approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christarazi christarazi added this pull request to the merge queue Nov 23, 2023
Merged via the queue into cilium:main with commit 1d4a013 Nov 23, 2023
@christarazi christarazi deleted the pr/christarazi/metrics-eventts-cleanup branch November 23, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancez chancez chancez approved these changes

@qmonnet qmonnet qmonnet approved these changes

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet nathanjsweet is a code owner automatically assigned from cilium/sig-policy

Assignees
No one assigned
Labels
area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christarazi @chancez @qmonnet