-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix ImplementationSpecific
path sorting for Ingress
#29381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08804f3
to
8f7ad45
Compare
/test |
2 tasks
Looks like the clustermesh tests failed to pull the images, retrying. |
/test ci-clustermesh |
meyskens
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d4362e5
to
9f2bafe
Compare
/test |
This commit makes a few changes: Adds a new test for ingestion, that tests how multiple path matches in the same Ingress work Updates translation logic to sort into the order Exact, Regex, Prefix, which means that regex matches that overlap with prefixes will now route traffic. Adds more cases to the unit tests for SortableRoute.Less(), which ensures that more options are covered. Also refactors the TestSharedIngressTranslator_getEnvoyHTTPRouteConfiguration test to also check the contents of the path and cluster matches, as well as just the listener name and virtual host name. This was quite a bit more complex, because just comparing protobufs produces very unhelpful failure outputs. This test design makes it more straightforward to correct errors in the expected results. Signed-off-by: Nick Young <nick@isovalent.com>
9f2bafe
to
b3f99db
Compare
/test |
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/servicemesh
GH issues or PRs regarding servicemesh
feature/k8s-ingress
kind/bug
This is a bug in the Cilium logic.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sorting logic for Ingress (and, by extension, Gateway API), by fixing the model translation output step so that
ImplementationSpecific
(that is, regex) matches always come beforePrefix
matches, but afterExact
matches.It also updates the testing to ensure that changes here are caught, and updates some wording in the godoc to clarify the algorithm used for translation out of the model to Envoy config.
Fixes: #28852