Skip to content

Improved BGP docs on MD5 #29375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

Improved BGP docs on MD5 #29375

merged 1 commit into from
Dec 1, 2023

Conversation

nvibert
Copy link
Contributor

@nvibert nvibert commented Nov 25, 2023 

Minor documentation fixes and improvements for the BGP MD5 feature

@nvibert nvibert requested review from a team as code owners November 25, 2023 12:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 25, 2023
YutaroHayakawa
YutaroHayakawa approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

qmonnet
qmonnet requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall, with some suggestions on the phrasing.

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. area/bgp Impacts the Border Gateway Protocol feature. labels Nov 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 27, 2023
qmonnet
qmonnet approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please squash the two commits together.

rastislavs
rastislavs approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nvibert @qmonnet
Improved BGP docs on MD5
4b26ae9 
Update Documentation/network/bgp-control-plane.rst

Co-authored-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Nico Vibert <nicolas.vibert@isovalent.com>
@mhofstetter
Copy link
Member

/test

@mhofstetter
Copy link
Member

mhofstetter commented Nov 30, 2023 •
edited
Loading

Adding ready-to-merge: all approvals are in and docs change only (/tests didn't skip ci-ipsec-e2e properly)

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 30, 2023
@youngnick youngnick merged commit 9dcff21 into cilium:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@rastislavs rastislavs rastislavs approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nvibert @mhofstetter @YutaroHayakawa @rastislavs @qmonnet @youngnick