Skip to content

Switch to on-demand instances for AWS tests on scheduled runs. #29366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Nov 24, 2023

More context in the issue.

Related: #29365

@marseel marseel added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 24, 2023
@marseel
Copy link
Contributor Author

marseel commented Nov 24, 2023

/ci-eks

@marseel marseel force-pushed the use_on_demand_instances_for_aws_tests branch from 631542b to 031a830 Compare November 24, 2023 13:35
@marseel
Copy link
Contributor Author

marseel commented Nov 24, 2023

/ci-eks

@marseel marseel force-pushed the use_on_demand_instances_for_aws_tests branch from 031a830 to 7626749 Compare November 24, 2023 14:51
@marseel
Copy link
Contributor Author

marseel commented Nov 24, 2023

run with spot set to false: https://github.com/cilium/cilium/actions/runs/6981426957/job/18998539323
manually set: 031a830

@marseel
Copy link
Contributor Author

marseel commented Nov 24, 2023

/ci-eks

@marseel
Copy link
Contributor Author

marseel commented Nov 24, 2023

/ci-awscni

@marseel marseel marked this pull request as ready for review November 24, 2023 15:51
@marseel marseel requested review from a team as code owners November 24, 2023 15:51
Related: #29365

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the use_on_demand_instances_for_aws_tests branch from 7626749 to b8a83a4 Compare November 24, 2023 19:06
@marseel
Copy link
Contributor Author

marseel commented Nov 27, 2023

/ci-eks

@marseel
Copy link
Contributor Author

marseel commented Nov 27, 2023

/ci-awscni

@marseel
Copy link
Contributor Author

marseel commented Nov 27, 2023

Both relevant tests passed, marking as ready-to-merge

@marseel marseel added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 27, 2023
@aanm aanm merged commit 83cbb19 into main Nov 27, 2023
@aanm aanm deleted the use_on_demand_instances_for_aws_tests branch November 27, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants