Skip to content

bpf: tests: minor cleanups #29354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2023
Merged

bpf: tests: minor cleanups #29354

merged 2 commits into from
Nov 28, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Nov 23, 2023 •
edited
Loading

Two straight-forward changes to remove duplicated / unused parts in the datapath tests.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 23, 2023
@julianwiedmann
Copy link
Member Author

/ci-verifier

@julianwiedmann
bpf: tests: remove duplicated compile-test option combinations
53af348 
abe1b38 ("bpf: remove HAVE_FIB_LOOKUP leftovers from compile tests")
left some duplicated combinations behind. Clean them up.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: tests: remove HAVE_{LPM_TRIE,LRU_HASH}_MAP_TYPE leftovers
9a16925 
The datapath no longer uses these macros.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the 1.15-bpf-complexity-features branch from 781fb7b to 9a16925 Compare November 26, 2023 09:23
@julianwiedmann julianwiedmann added area/CI Continuous Integration testing issue or flake area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Nov 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 26, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title 1.15 bpf complexity features bpf: tests: minor cleanups Nov 26, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review November 27, 2023 06:34
@julianwiedmann julianwiedmann requested review from a team as code owners November 27, 2023 06:34
@julianwiedmann julianwiedmann requested review from rgo3 and aspsk November 27, 2023 06:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2023
@julianwiedmann julianwiedmann added this pull request to the merge queue Nov 28, 2023
Merged via the queue into cilium:main with commit 64f3e55 Nov 28, 2023
@julianwiedmann julianwiedmann deleted the 1.15-bpf-complexity-features branch November 28, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

@rgo3 rgo3 rgo3 approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianwiedmann @aspsk @rgo3