Skip to content

Conversation

pchaigno
Copy link
Member

To detect that the key rotation began or that it successfully ended, we rely on the number of keys in use reported by
cilium-dbg encrypt status. When either of those steps times out, it would be good to have information on what the number of keys was.

This pull request adds that debug information to the test.

To detect that the key rotation began or that it successfully ended, we
rely on the number of keys in use reported by
`cilium-dbg encrypt status`. When either of those steps times out, it
would be good to have information on what the number of keys was.

This commit adds that debug information to the test.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. needs-backport/1.12 labels Nov 23, 2023
@pchaigno
Copy link
Member Author

/ci-ipsec-e2e

@pchaigno pchaigno requested a review from rgo3 November 24, 2023 10:01
@pchaigno pchaigno marked this pull request as ready for review November 24, 2023 10:01
@pchaigno pchaigno requested review from a team as code owners November 24, 2023 10:01
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 27, 2023
@pchaigno pchaigno enabled auto-merge November 27, 2023 12:34
@youngnick youngnick disabled auto-merge November 28, 2023 03:30
@youngnick youngnick merged commit a6e22ba into cilium:main Nov 28, 2023
@pchaigno pchaigno deleted the ipsec-workflow-debug-info branch November 28, 2023 09:02
@joamaki joamaki mentioned this pull request Nov 29, 2023
4 tasks
@joamaki joamaki mentioned this pull request Nov 29, 2023
4 tasks
@joamaki joamaki mentioned this pull request Nov 29, 2023
14 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Nov 29, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.12 labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Released
Status: Released
Status: Released
Development

Successfully merging this pull request may close these issues.

6 participants