Skip to content

show DSR-dispatch mode in cilium-dbg status #29217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2023
Merged

show DSR-dispatch mode in cilium-dbg status #29217

merged 1 commit into from
Nov 18, 2023

Conversation

chaunceyjiang
Copy link
Member

Fixes: #29132

show DSR-dispatch mode in cilium-dbg status

@chaunceyjiang chaunceyjiang requested review from a team as code owners November 16, 2023 01:46
@chaunceyjiang chaunceyjiang requested a review from aanm November 16, 2023 01:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 16, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Nov 16, 2023
@chaunceyjiang
Copy link
Member Author

chaunceyjiang commented Nov 16, 2023 •
edited
Loading

image

Test:

image

@julianwiedmann julianwiedmann self-requested a review November 16, 2023 18:27
@julianwiedmann julianwiedmann added area/cli Impacts the command line interface of any command in the repository. area/loadbalancing Impacts load-balancing and Kubernetes service implementations kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Nov 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 16, 2023
julianwiedmann
julianwiedmann requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this! Just a few small change suggestions below.

@chaunceyjiang chaunceyjiang force-pushed the dsr branch 2 times, most recently from 4906724 to 8468438 Compare November 16, 2023 19:23
@chaunceyjiang
Copy link
Member Author

image

@chaunceyjiang @julianwiedmann
show DSR-dispatch mode in cilium-dbg status
dc60f36 
Fixes: cilium#29132

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@julianwiedmann
Copy link
Member

/test

julianwiedmann
julianwiedmann approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy, thank you @chaunceyjiang !

(@aanm , it's all yours)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 18, 2023
@aanm aanm merged commit c3404c9 into cilium:main Nov 18, 2023
@chaunceyjiang chaunceyjiang deleted the dsr branch January 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. area/loadbalancing Impacts load-balancing and Kubernetes service implementations kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kpr: show DSR-dispatch mode in cilium-dbg status
3 participants
@chaunceyjiang @julianwiedmann @aanm