Skip to content

Conversation

thorn3r
Copy link
Contributor

@thorn3r thorn3r commented Nov 15, 2023

Revert "dnsproxy: Use original source address in connections to dns servers"

This reverts commit 277037f.

This change was reverted in main at 4dc8ca2.

Since this was an author backport and required special care, I'm reverting the commit in the branch rather than backporting.

[upstream commit 4dc8ca2 ]

Fixes: #29175

Revert "dnsproxy: Use original source address in connections to dns servers" to fix performance regression.

@thorn3r thorn3r requested a review from a team as a code owner November 15, 2023 20:49
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Nov 15, 2023
…rvers

This reverts commit 277037f.

This change was reverted in main at 4dc8ca2.

Since this was an author backport and required special care, I'm
reverting the commit in the branch rather than backporting.

[upstream commit 4dc8ca2 ]

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
@thorn3r thorn3r force-pushed the v1.14-revert-proxy-og-source branch from 6335592 to dff4339 Compare November 15, 2023 20:56
@thorn3r
Copy link
Contributor Author

thorn3r commented Nov 15, 2023

/test

@thorn3r
Copy link
Contributor Author

thorn3r commented Nov 15, 2023

/test-backport-1.14

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 15, 2023
@gandro gandro merged commit 5e66a9e into cilium:v1.14 Nov 16, 2023
@sergeyshevch
Copy link
Contributor

sergeyshevch commented Jan 22, 2024

@thorn3r Is it possible to edit 1.14.4 release description on github to include mention of this bug and that it's fixed in 1.14.5. It was really bad experience to get 5 cores cpu consumption on production after upgrade to 1.14.4

@thorn3r
Copy link
Contributor Author

thorn3r commented Jan 23, 2024

Hey @sergeyshevch, sorry to hear about your troubles with that regression in v1.14.4. We don't typically update previous release notes, but the fix is called out in the v1.14.5 release notes under Other Changes. This should have been listed under Bugfixes instead, but that is a side-effect of this one not following the standard backporting procedure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v1.14 This issue affects v1.14 branch backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

5 participants