Skip to content

Revert "dnsproxy: Use original source address in connections to dns servers" #29202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

Revert "dnsproxy: Use original source address in connections to dns servers" #29202

merged 1 commit into from
Nov 15, 2023

Conversation

thorn3r
Copy link
Contributor

@thorn3r thorn3r commented Nov 15, 2023

Revert "dnsproxy: Use original source address in connections to dns servers"

This reverts commit 9d70db8.

This commit caused a reported performance regression

Fixes: #29175

Revert "dnsproxy: Use original source address in connections to dns servers" to fix performance regression.

@maintainer-s-little-helper
Copy link

Commit 22eca37 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 15, 2023
@thorn3r thorn3r force-pushed the revert-proxy-og-source branch from 22eca37 to f29325d Compare November 15, 2023 18:33
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 15, 2023
@thorn3r thorn3r added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2023
@thorn3r
Revert dnsproxy: Use original source address in connections to dns se…
ee96de5 
…rvers

This reverts commit 9d70db8.

Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
@thorn3r thorn3r force-pushed the revert-proxy-og-source branch from f29325d to ee96de5 Compare November 15, 2023 18:36
@thorn3r
Copy link
Contributor Author

thorn3r commented Nov 15, 2023

/test

@thorn3r thorn3r marked this pull request as ready for review November 15, 2023 18:48
@thorn3r thorn3r requested review from a team as code owners November 15, 2023 18:48
@aanm aanm added the kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. label Nov 15, 2023
@aanm aanm merged commit 4dc8ca2 into cilium:main Nov 15, 2023
@thorn3r
Copy link
Contributor Author

thorn3r commented Nov 15, 2023

rather than backporting, the relevant commit will be reverted in each branch:
v1.12: #29209
v1.13: #29206
v1.14: #29205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh is a code owner automatically assigned from cilium/vendor

@jibi jibi Awaiting requested review from jibi jibi was automatically assigned from cilium/sig-agent

@jrajahalme jrajahalme Awaiting requested review from jrajahalme jrajahalme was automatically assigned from cilium/proxy

Assignees
No one assigned
Labels
kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive CPU usage when utilizing dnsproxy
3 participants
@thorn3r @aanm @michi-covalent