bgpv1: Reorganize BGP config reconcilers #29277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e299616 to
47bd5e6
Compare
This is a code cleanup change for enhancing code readability and modularity, without any functional changes. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
Splits recocnilers and their tests from a single source file to a file per reconciler to avoid unnecessary code conflicts. This change does not touch the logic of any reconciler, just moves the code into newly created source files as it is. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
f6a2408 to
1e52e13
Compare
|
/test |
harsimran-pabla
approved these changes
Nov 21, 2023
Moves BGP Manager reconcilers into a separate package manager/reconciler to achieve cleaner file structure and separation from the main BGP Manager logic. Also moves DiffStore & BGPCPResourceStore into a new package manager/store, and ServerWithConfig type into a new package manager/instance to avoid cyclic dependencies. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
1e52e13 to
87729e7
Compare
|
/test |
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Nov 22, 2023
This commit fixes the build caused by a merge race between the following PRs cilium#28474 cilium#29277 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
This commit fixes the build caused by a merge race between the following PRs cilium#28474 cilium#29277 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to re-organize BGP
ConfigReconcilers to achieve a better structure and avoid conflicts in case of concurrent changes.The most significant change is moving the code from a huge single source file (
pkg/bgpv1/manager/reconcile.go+ co-locatedreconcile_test.go) to multiple files, one source + test file per each reconciler. The changes are only structural, there is no functional change. For more details, please see commit messages in the individual commits.