Skip to content

CI: Add merge_group trigger #29276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

CI: Add merge_group trigger #29276

merged 1 commit into from
Nov 22, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Nov 20, 2023

This PR adds merge_group trigger to workflows that have required checks.
"Installation and Conformance Test" in smoke-test-ipv6 workflow is renamed as "Installation and Conformance Test (ipv6)" to distinguish the check from the one that is in smoke-test workflow.
This way this check can also be added to required checks without mixup.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 20, 2023
@brlbil brlbil added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 20, 2023
@brlbil
ci: add merge_group trigger
4418888 
This commit adds merge_group trigger to workflows that have
required checks. "Installation and Conformance Test" in smoke-test-ipv6 workflow
is renamed as "Installation and Conformance Test (ipv6)" to distinguish
the check from the one that is in smoke-test workflow. This way this check can also
be added to required checks without mixup.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-add-merge-group branch from 2e3f8b7 to 4418888 Compare November 21, 2023 09:30
@brlbil
Copy link
Contributor Author

brlbil commented Nov 21, 2023

/test

@brlbil brlbil marked this pull request as ready for review November 21, 2023 10:19
@brlbil brlbil requested review from a team as code owners November 21, 2023 10:19
@brlbil brlbil requested review from nbusseneau and aanm November 21, 2023 10:19
@brlbil brlbil requested review from viktor-kurchenko and removed request for nbusseneau November 21, 2023 14:21
viktor-kurchenko
viktor-kurchenko approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 21, 2023
@lmb lmb merged commit 50b5b93 into main Nov 22, 2023
@lmb lmb deleted the pr/brlbil/ci-add-merge-group branch November 22, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brlbil @aanm @viktor-kurchenko @lmb