Skip to content

client: Use options pattern for NewRuntime #29271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

client: Use options pattern for NewRuntime #29271

merged 1 commit into from
Nov 22, 2023

Conversation

gandro
Copy link
Member

@gandro gandro commented Nov 20, 2023

Instead of passing in a list of strings, use an options pattern which makes call-sites easier to read.

Suggested-by: Marco Hofstetter marco.hofstetter@isovalent.com

@gandro
client: Use options pattern for NewRuntime
a5bc6ac 
Instead of passing in a list of strings, use an options pattern which
makes call-sites easier to read.

Suggested-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Nov 20, 2023
@gandro gandro requested a review from mhofstetter November 20, 2023 11:17
@gandro gandro requested review from a team as code owners November 20, 2023 11:17
@gandro gandro requested a review from learnitall November 20, 2023 11:17
@gandro
Copy link
Member Author

gandro commented Nov 20, 2023

/test

@gandro gandro mentioned this pull request Nov 20, 2023
Merged
mhofstetter
mhofstetter reviewed Nov 20, 2023
View reviewed changes
mhofstetter
mhofstetter approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gandro

learnitall
learnitall approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 21, 2023
@gandro gandro merged commit aa6752e into cilium:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

+1 more reviewer

@learnitall learnitall learnitall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/cli Impacts the command line interface of any command in the repository. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gandro @mhofstetter @learnitall