Add CEP and CES resources #29244
Merged
Add CEP and CES resources #29244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
This was referenced Nov 17, 2023
This was referenced Nov 18, 2023
tommyp1ckles
approved these changes
Nov 20, 2023
YutaroHayakawa
approved these changes
Nov 22, 2023
CiliumSlimEndpoint resource is built using the constructor in pkg/k8s, the same one used by the agent. This limits the flexibility of the constructor, since it is not possible to modify it for the agent or the clustermesh-apiserver specific needs. As an example, the agent starts a CEP informer with an indexer that reads the local node IP, but since the clustermesh-apiserver does not have any cell providing LocalNodeStore, we cannot use that indexer there (clustermesh-apiserver will panic as soon as Resource[CiliumSlimEndpoint] receives an update). To avoid this, the clustermesh-apiserver is modified to use its own CiliumSlimEndpoint constructor, just like we did in the operator for all the k8s resources. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
In order to migrate the current agent CEP watcher to Resource[T], the commit adds the same indexer used in the watcher to the CiliumSlimEndpoint resource. The indexer accesses the local node to get its IP. Differently from the previous indexer implementation, it is mandatory to do that when the indexer function is actually called, otherwise we might panic trying to read an uninitialized local node store reference. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Add a new constructor for the CiliumEndpointSlice resource. This will be used to migrate the current implementation of the k8s CES watcher to Resource[T]. The resource indexer accesses the local node to get its IP. Differently from the previous indexer implementation in the watcher, it is mandatory to do that when the indexer function is actually called, otherwise we might panic trying to read an uninitialized local node store reference. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
Enable Resource[T] metrics for CiliumSlimEndpoint resource. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
9f6891d to
1d38cd2
Compare
|
@tommyp1ckles @YutaroHayakawa I've made a small change to the |
|
/test |
You're not authorized to push to this branch. Visit "About protected branches" for more information.
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a required step to migrate the k8s CEP watchers to Resource[T].
First, the PR adds a separate constructor for the CiliumSlimEndpoint resource in the clustermesh-apiserver. The apiserver is currently using the same constructor used by the agent and this limits the ability to add indexers that depend on agent-specific part.
Then, the PR adds the CES resource constructor and the same indexers already used by the informers in the CEP and CES k8s watchers.
Refer to this comment and to the individual commit messages for more information.
Related: #28159